mirror of
https://github.com/Keychron/qmk_firmware.git
synced 2024-11-22 16:37:58 +06:00
acda2b793f
There was an odd case, which confused the hell out of tap-dance: suppose you had a number of tap-dance keys, on a layer, and as part of the tap-dance, you turned that layer off - or had it on one-shot to begin with. In this case, the keydown event would trigger the tap-dance key, but the keyup would not. This had two funky consequences: - tap-dance did not correctly register that the dance has ended. - pressing any other tap-dance key would interrupt the previous tap-dance, and potentially input unwanted characters. To fix this, we simply do not start a tap-dance sequence on keyup, only when it is pressed. This way the previous sequence has enough time to time-out and finish properly, and we don't get confused. This fixes algernon/ergodox-layout#107. Signed-off-by: Gergely Nagy <algernon@madhouse-project.org> |
||
|---|---|---|
| .. | ||
| audio | ||
| keymap_extras | ||
| process_keycode | ||
| serial_link | ||
| template | ||
| tools | ||
| visualizer | ||
| analog.c | ||
| analog.h | ||
| config_common.h | ||
| dynamic_macro.h | ||
| keycode_config.c | ||
| keycode_config.h | ||
| keymap_common.c | ||
| keymap.h | ||
| light_ws2812.c | ||
| light_ws2812.h | ||
| matrix.c | ||
| quantum.c | ||
| quantum.h | ||
| rgblight.c | ||
| rgblight.h | ||