Update q8

keyboards/keychron/q4/config.h

@@ -116,6 +116,6 @@
 
 // Just for testing RGB matrix
 // preventing inadvertent entry into dfu mode during power on
-#define RGB_MATRIX_KEYPRESSES
+// #define RGB_MATRIX_KEYPRESSES
 #define BOOTMAGIC_LITE_ROW 4
 #define BOOTMAGIC_LITE_COLUMN 5

keyboards/keychron/q9/config.h

@@ -19,7 +19,7 @@
 /* USB Device descriptor parameter */
 #define VENDOR_ID       0x3434
 #define MANUFACTURER    Keychron
-#define PRODUCT         Keychron Q9
+#define PRODUCT         Keychron Q8
 
 /* COL2ROW or ROW2COL */
 #define DIODE_DIRECTION ROW2COL

keyboards/keychron/q9/q8.c

@@ -14,15 +14,15 @@
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
-#include "q9.h"
+#include "q8.h"
 #include "test.c"
 
 const matrix_row_t matrix_mask[] = {
-    0b1111111111111111,
-    0b1111111111111111,
-    0b1111111111111111,
-    0b1111111111111111,
-    0b1111111111101111,
+    0b111111111111111,
+    0b111111111111111,
+    0b111111111111111,
+    0b111111111111111,
+    0b111111111101111,
 };
 
 bool dip_switch_update_kb(uint8_t index, bool active) {

keyboards/keychron/q9/q8.h

@@ -18,8 +18,8 @@
 
 #include "quantum.h"
 
-#if defined(KEYBOARD_keychron_q9_q9_ansi_stm32l432)
-#    include "q9_ansi_stm32l432.h"
-#elif defined(KEYBOARD_keychron_q9_q9_ansi_stm32l432_ec11)
-#    include "q9_ansi_stm32l432_ec11.h"
+#if defined(KEYBOARD_keychron_q8_q8_ansi_stm32l432)
+#    include "q8_ansi_stm32l432.h"
+#elif defined(KEYBOARD_keychron_q8_q8_ansi_stm32l432_ec11)
+#    include "q8_ansi_stm32l432_ec11.h"
 #endif

keyboards/keychron/q9/q8_ansi_stm32l432/config.h

@@ -17,7 +17,7 @@
 #pragma once
 
 /* USB Device descriptor parameter */
-#define PRODUCT_ID 0x0190
+#define PRODUCT_ID 0x0180
 #define DEVICE_VER 0x0100
 
 /* RGB Matrix Configuration */

keyboards/keychron/q9/q8_ansi_stm32l432/info.json

@@ -1,5 +1,5 @@
 {
-    "keyboard_name": "Keychron Q9",
+    "keyboard_name": "Keychron Q8",
     "url": "https://github.com/Keychron",
     "maintainer": "lalalademaxiya1",
     "layouts": {

keyboards/keychron/q9/q8_ansi_stm32l432/q9_ansi_stm32l432.c

@@ -17,6 +17,7 @@
 #include "quantum.h"
 
 #ifdef RGB_MATRIX_ENABLE
+
 const ckled2001_led PROGMEM g_ckled2001_leds[DRIVER_LED_TOTAL] = {
 /* Refer to CKLED manual for these locations
  *   driver
@@ -123,4 +124,5 @@ led_config_t g_led_config = {
         4,    4,    4,          4,          4,          4,    4,          4,          4,    4,    4
     }
 };
+
 #endif

keyboards/keychron/q9/q8_ansi_stm32l432/readme.md

@@ -0,0 +1 @@
+# The ANSI variant of the Keychron Q8

keyboards/keychron/q9/q9_ansi_stm32l432/readme.md

@@ -1 +0,0 @@
-# The ANSI variant of the Keychron Q9

keyboards/keychron/q9/readme.md

@@ -1,18 +1,18 @@
-# Keychron Q9
+# Keychron Q8
 
-A customizable 60% keyboard.
+A customizable 65% and ergonomic keyboard.
 
 * Keyboard Maintainer: [Keychron](https://github.com/keychron)
-* Hardware Supported: Keychron Q9
+* Hardware Supported: Keychron Q8
 * Hardware Availability: [Keychron](https://www.keychron.com)
 
 Make example for this keyboard (after setting up your build environment):
 
-    make keychron/q9/q9_ansi_stm32l432:default
+    make keychron/q8/q8_ansi_stm32l432:default
 
 Flashing example for this keyboard ([after setting up the bootloadHID flashing environment](https://docs.qmk.fm/#/flashing_bootloadhid))
 
-    make keychron/q9/q9_ansi_stm32l432:default:flash
+    make keychron/q8/q8_ansi_stm32l432:default:flash
 
 **Reset Key**: Hold down the key located at *K00*, commonly programmed as *Esc* while plugging in the keyboard.