check bare paths in scripts/, and record why one file has no .sh

Two answers to "add .sh to sh files". Exactly one file lacks the suffix:
scripts/hooks/pre-commit. git locates a hook by exact filename, so renaming it
would leave a gate that looks present and does nothing — verified in a throwaway
repository, where hooks/pre-commit printed and hooks/pre-commit.sh was ignored
while the commit succeeded regardless. The name belongs to git, so the file keeps
it and conventions.md now states the exception rather than leaving it as an
inconsistency someone will try to tidy again.

The extension was never the defect anyway. The dangling-path gate had only ever
matched backticked citations, so `git add docs/surface.md` in the hook — an
argument, not a citation — survived the docs/ rename and surfaced as a fatal
inside a commit that otherwise succeeded. That gate now also reads paths in
scripts/ unquoted, which is the check that would have caught it.

Proven both ways: restoring the exact bug fails the gate with "reference to a
path that does not exist: docs/surface.md", and a working tree passes. The first
attempt did not catch it — docs had been dropped from the alternation because the
directory no longer exists, which is precisely the class of stale reference worth
failing on, so docs is in the bare pattern on purpose.

Backslashes are stripped before comparing, so a path written as a regex —
\.claude/settings\.json — is checked as the file it means rather than flagged as
the file it is not. Prose is still checked only inside backticks: a sentence
saying "under harness/" makes a point no filesystem can verify, while a script
naming a path either has it right or is broken.

One gate label changed with it. `pass "harness/HARNESS.md coupling"` read fine
while the directory was docs/ and now parses as a filename, which the new check
duly flagged; it is "harness and HARNESS.md move together". No doc cited the old
label.

4 files. No rule or threshold moved — one gate widened, one convention written down.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
2026-08-02 20:49:08 +06:00
co-authored by Claude Opus 5
parent 07cf655d09
commit 078ec8eedf
3 changed files with 28 additions and 5 deletions
+7
View File
@@ -43,6 +43,13 @@ wants splitting.
because a forgotten expiry serves staleness silently.
- Comments explain *why*, never *what*. Delete a comment narrating the next line. One stating a
non-obvious invariant is worth ten describing control flow.
- **Shell scripts end in `.sh`, with exactly one exception: `scripts/hooks/pre-commit`.** git locates a
hook by exact filename, so a `.sh` suffix makes it invisible and the gate stops running on every commit
while still appearing to exist — verified by renaming it in a throwaway repository and watching a commit
succeed with the hook silent. The name belongs to git, not to this convention. Consequence worth
remembering: a repo-wide sweep filtered by `--include='*.sh'` walks past that file, which is how a stale
path survived in it (ADR-0082), so `verify.sh` now checks the paths inside `scripts/` whether or not they
are quoted.
## Documentation