check bare paths in scripts/, and record why one file has no .sh

Two answers to "add .sh to sh files". Exactly one file lacks the suffix:
scripts/hooks/pre-commit. git locates a hook by exact filename, so renaming it
would leave a gate that looks present and does nothing — verified in a throwaway
repository, where hooks/pre-commit printed and hooks/pre-commit.sh was ignored
while the commit succeeded regardless. The name belongs to git, so the file keeps
it and conventions.md now states the exception rather than leaving it as an
inconsistency someone will try to tidy again.

The extension was never the defect anyway. The dangling-path gate had only ever
matched backticked citations, so `git add docs/surface.md` in the hook — an
argument, not a citation — survived the docs/ rename and surfaced as a fatal
inside a commit that otherwise succeeded. That gate now also reads paths in
scripts/ unquoted, which is the check that would have caught it.

Proven both ways: restoring the exact bug fails the gate with "reference to a
path that does not exist: docs/surface.md", and a working tree passes. The first
attempt did not catch it — docs had been dropped from the alternation because the
directory no longer exists, which is precisely the class of stale reference worth
failing on, so docs is in the bare pattern on purpose.

Backslashes are stripped before comparing, so a path written as a regex —
\.claude/settings\.json — is checked as the file it means rather than flagged as
the file it is not. Prose is still checked only inside backticks: a sentence
saying "under harness/" makes a point no filesystem can verify, while a script
naming a path either has it right or is broken.

One gate label changed with it. `pass "harness/HARNESS.md coupling"` read fine
while the directory was docs/ and now parses as a filename, which the new check
duly flagged; it is "harness and HARNESS.md move together". No doc cited the old
label.

4 files. No rule or threshold moved — one gate widened, one convention written down.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
2026-08-02 20:49:08 +06:00
co-authored by Claude Opus 5
parent 07cf655d09
commit 078ec8eedf
3 changed files with 28 additions and 5 deletions
+9 -3
View File
@@ -256,9 +256,15 @@ that describe it, in the same change.**
say why. The hook also regenerates `harness/surface.md` and stages it, so a generated file is never
something you have to remember — and it refuses a commit with unstaged `.go` changes, because what it
generated describes the working tree rather than what you are committing. It carries **no file
extension**, so a repo-wide sweep filtered by `--include='*.sh'` walks straight past it: ADR-0082's
rename left it staging a path that no longer existed, and the failure surfaced as a `fatal:` from inside
a commit that otherwise succeeded. When renaming anything the gate names, grep without an include filter.
extension** because git locates a hook by exact name — the one exception to "shell scripts end in `.sh`"
(`conventions.md`), confirmed by renaming it in a throwaway repo and watching a commit succeed with the
hook silent. A `.sh` suffix there would leave a gate that looks present and does nothing.
- **Paths inside `scripts/` are checked whether or not they are quoted.** The dangling-path gate had only
ever matched backticked citations, so `git add docs/surface.md` in the hook — an argument, not a
citation — survived ADR-0082's rename and surfaced as a `fatal:` inside a commit that otherwise
succeeded. Backslashes are stripped first, so a path written as a regex is compared as the file it
means. Prose is still checked only in backticks: a sentence saying "under `harness/`" is making a point
a filesystem cannot check, while a script naming a path either has it right or is broken.
- `harness/decisions.md` registers every ADR number ever used, entries and withdrawals alike, so a citation
can resolve to a decision or to a deferral but never to nothing.
- `./scripts/verify.sh --list` names every gate that exists. A doc claiming enforcement is checkable
+7
View File
@@ -43,6 +43,13 @@ wants splitting.
because a forgotten expiry serves staleness silently.
- Comments explain *why*, never *what*. Delete a comment narrating the next line. One stating a
non-obvious invariant is worth ten describing control flow.
- **Shell scripts end in `.sh`, with exactly one exception: `scripts/hooks/pre-commit`.** git locates a
hook by exact filename, so a `.sh` suffix makes it invisible and the gate stops running on every commit
while still appearing to exist — verified by renaming it in a throwaway repository and watching a commit
succeed with the hook silent. The name belongs to git, not to this convention. Consequence worth
remembering: a repo-wide sweep filtered by `--include='*.sh'` walks past that file, which is how a stale
path survived in it (ADR-0082), so `verify.sh` now checks the paths inside `scripts/` whether or not they
are quoted.
## Documentation
+12 -2
View File
@@ -92,7 +92,7 @@ if [ -d .git ] && command -v git >/dev/null 2>&1; then
if [ -n "$harnesschanged" ] && ! echo "$changed" | grep -qx 'HARNESS.md'; then
bad "the harness changed (CLAUDE.md, scripts/ or .claude/) but HARNESS.md did not — the guide to the machine is part of the machine"
else
pass "harness/HARNESS.md coupling"
pass "harness and HARNESS.md move together"
fi
fi
@@ -142,8 +142,18 @@ if [ -d .git ] && command -v git >/dev/null 2>&1; then
[ -d .scratch ] && scratchpat='|\.scratch'
refs=$(grep -rhoE "\`(harness|scripts|ideas|reference|\.claude$scratchpat)/[A-Za-z0-9_./-]+\`" \
harness CLAUDE.md HARNESS.md ideas reference .claude scripts 2>/dev/null | tr -d '`' | sort -u)
# Bare paths in the gate's own scripts, where a backtick is prose but the path is what actually runs.
# `git add harness/surface.md` in the pre-commit hook is not a citation, it is an argument — and the hook
# staged a deleted path for two commits because this check had only ever looked inside backticks. Only
# scripts/ is scanned bare: prose says "under harness/" for reasons a filesystem cannot check, while a
# shell script naming a path either has it right or is broken.
#
# Backslashes are stripped first, so a path written as a regex — `\.claude/settings\.json` — is compared
# as the file it means rather than flagged as the file it is not.
bare=$(sed 's/\\//g' $(find scripts -type f) 2>/dev/null |
grep -ohE '(harness|docs|scripts|ideas|reference)/[A-Za-z0-9_./-]+' | sed 's/[.]$//' | sort -u)
dangling=""
for f in $refs; do [ -e "$f" ] || dangling="$dangling $f"; done
for f in $refs $bare; do [ -e "$f" ] || dangling="$dangling $f"; done
[ -n "$dangling" ] && bad "reference to a path that does not exist:$dangling"
adrs=$(grep -rhoE 'ADR-[0-9]{4}' harness CLAUDE.md HARNESS.md ideas reference .claude scripts cmd internal 2>/dev/null | sort -u)