mirrors/keychron_qmk_firmware
mirrors/keychron_qmk_firmware
0
0
Fork 0
mirror of https://github.com/Keychron/qmk_firmware.git synced 2024-11-29 12:17:50 +06:00
Code Issues Packages Projects Releases Wiki Activity

Fix wrong key when "Music Map" is used with MAJOR_MODE. (#11234)

Browse Source 
With MAJOR_MODE (= major scale), keys in one octave is not 12 but 7.
To solve this problem, change divisor number from 12 to 7 at %(Modulo) and /(Division).

NOTE:
The last 12 represents half step keys in one octave for pitch calculation.
This commit is contained in:
Takeshi Nishio 2021-01-20 11:08:06 +09:00 committed by GitHub
parent 974d3f1ffd
commit 71f067a60e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
quantum/process_keycode/process_music.c
View File

@ -191,7 +191,7 @@ bool process_music(uint16_t keycode, keyrecord_t *record) {
note = music_starting_note + music_offset + 36 + music_map[record->event.key.row][record->event.key.col]; note = music_starting_note + music_offset + 36 + music_map[record->event.key.row][record->event.key.col];
} else { } else {
uint8_t position = music_map[record->event.key.row][record->event.key.col]; uint8_t position = music_map[record->event.key.row][record->event.key.col];
note = music_starting_note + music_offset + 36 + SCALE[position % 12] + (position / 12) * 12; note = music_starting_note + music_offset + 36 + SCALE[position % 7] + (position / 7) * 12;
} }
# else # else
if (music_mode == MUSIC_MODE_CHROMATIC) if (music_mode == MUSIC_MODE_CHROMATIC)